Valgrind: r16219 - in /trunk: NEWS glibc-2.34567-NPTL-helgrind.supp

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Valgrind: r16219 - in /trunk: NEWS glibc-2.34567-NPTL-helgrind.supp

svn-2
Author: petarj
Date: Fri Feb  3 00:34:52 2017
New Revision: 16219

Log:
add suppression for helgrind/tests/tc22_exit_w_lock

Function pthread_create indirectly calls function memcpy. Helgrind
considers that memcpy is not thread safe function. For error reported
from pthread_create there is the suppression helgrind---_dl_allocate_tls
in the file glibc-2.34567-NPTL-helgrind.supp.
Since glibc version 2.23, memcpy is implemented by __mempcpy_inline.
This causes that call to memcpy from pthread_create is no longer
recognized by the suppression.
In test helgrind/tests/tc22_exit_w_lock, pthread_create is called twice,
and second call reports error, which causes failing of the test.
This patch adds suppression for glibc 2.23 and greater.

Patch by Tamara Vlahovic.

Related issue #375806.

Modified:
    trunk/NEWS
    trunk/glibc-2.34567-NPTL-helgrind.supp

Modified: trunk/NEWS
==============================================================================
--- trunk/NEWS (original)
+++ trunk/NEWS Fri Feb  3 00:34:52 2017
@@ -113,6 +113,7 @@
 375514  valgrind_get_tls_addr() does not work in case of static TLS
 375772  +1 error in get_elf_symbol_info() when computing value of 'hi' address
         for ML_(find_rx_mapping)()
+375806  Test helgrind/tests/tc22_exit_w_lock fails with glibc 2.24
 
 Release 3.12.0 (20 October 2016)
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Modified: trunk/glibc-2.34567-NPTL-helgrind.supp
==============================================================================
--- trunk/glibc-2.34567-NPTL-helgrind.supp (original)
+++ trunk/glibc-2.34567-NPTL-helgrind.supp Fri Feb  3 00:34:52 2017
@@ -267,6 +267,18 @@
    fun:pthread_create@*
 }
 
+{
+   helgrind---_dl_allocate_tls2
+   Helgrind:Race
+   fun:memcpy
+   fun:__mempcpy_inline
+   fun:_dl_allocate_tls_init
+   ...
+   fun:pthread_create@@GLIBC_2.2*
+   fun:pthread_create_WRK
+   fun:pthread_create@*
+}
+
 ####################################################
 # To do with GNU libgomp
 #


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Valgrind-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/valgrind-developers
Loading...