Valgrind: r16266 - /trunk/coregrind/m_syswrap/syswrap-linux.c

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Valgrind: r16266 - /trunk/coregrind/m_syswrap/syswrap-linux.c

svn-2
Author: philippe
Date: Sat Mar 11 21:07:21 2017
New Revision: 16266

Log:
Add missing break for the DRM ioctl operations that do not have any args
Due to this missing break, the code was falling through to
the case VKI_SNDRV_CTL_IOCTL_PVERSION:
and was then setting some bytes as defined at (whatever address is in) ARG3.

Patch and analysis by Daniel Glöckner


Modified:
    trunk/coregrind/m_syswrap/syswrap-linux.c

Modified: trunk/coregrind/m_syswrap/syswrap-linux.c
==============================================================================
--- trunk/coregrind/m_syswrap/syswrap-linux.c (original)
+++ trunk/coregrind/m_syswrap/syswrap-linux.c Sat Mar 11 21:07:21 2017
@@ -9520,6 +9520,8 @@
    case VKI_SNDRV_TIMER_IOCTL_STOP:
    case VKI_SNDRV_TIMER_IOCTL_CONTINUE:
    case VKI_SNDRV_TIMER_IOCTL_PAUSE:
+      break;
+
    case VKI_SNDRV_CTL_IOCTL_PVERSION: {
       POST_MEM_WRITE( (Addr)ARG3, sizeof(int) );
       break;


------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
Valgrind-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/valgrind-developers
Loading...