Valgrind: r16278 - /trunk/coregrind/m_syswrap/syswrap-linux.c

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Valgrind: r16278 - /trunk/coregrind/m_syswrap/syswrap-linux.c

svn-2
Author: philippe
Date: Fri Mar 17 18:45:23 2017
New Revision: 16278

Log:
And some more follow up for 376956 syswrap of SNDDRV and DRM_IOCTL_VERSION
causing some addresses to be wrongly marked as addressable

Just in case, do the assert after ARG2 has been truncated to 32 bits,
to avoid comparing sign extended requests on 64 bits.


Modified:
    trunk/coregrind/m_syswrap/syswrap-linux.c

Modified: trunk/coregrind/m_syswrap/syswrap-linux.c
==============================================================================
--- trunk/coregrind/m_syswrap/syswrap-linux.c (original)
+++ trunk/coregrind/m_syswrap/syswrap-linux.c Fri Mar 17 18:45:23 2017
@@ -9013,10 +9013,10 @@
 
 POST(sys_ioctl)
 {
-   vg_assert(SUCCESS || (FAILURE && VKI_DRM_IOCTL_VERSION == ARG2));
-
    ARG2 = (UInt)ARG2;
 
+   vg_assert(SUCCESS || (FAILURE && VKI_DRM_IOCTL_VERSION == ARG2));
+
    /* --- BEGIN special IOCTL handlers for specific Android hardware --- */
 
    /* BEGIN undocumented ioctls for PowerVR SGX 540 (the GPU on Nexus S) */


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Valgrind-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/valgrind-developers
Loading...