Quantcast

Valgrind: r16317 - /trunk/coregrind/m_ume/macho.c

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Valgrind: r16317 - /trunk/coregrind/m_ume/macho.c

svn-2
Author: rhyskidd
Date: Sat Apr 29 20:39:54 2017
New Revision: 16317

Log:
macos: Improve consistency of VG_(printf)() usage in coregrind/m_ume/macho.c. n-i-bz.

Identified in the process of reviewing a proposed fix for bz#365327.

Patch from Louis Brunner.

Modified:
    trunk/coregrind/m_ume/macho.c

Modified: trunk/coregrind/m_ume/macho.c
==============================================================================
--- trunk/coregrind/m_ume/macho.c (original)
+++ trunk/coregrind/m_ume/macho.c Sat Apr 29 20:39:54 2017
@@ -138,16 +138,12 @@
    res = VG_(open)(filename, VKI_O_RDONLY, 0);
    fd = sr_Res(res);
    if (sr_isError(res)) {
-      print("couldn't open dylinker: ");
-      print(filename);
-      print("\n");
+      VG_(printf)("couldn't open dylinker: %s\n", filename);
       return -1;
    }
    err = VG_(fstat)(fd, &sb);
    if (err) {
-      print("couldn't stat dylinker: ");
-      print(filename);
-      print("\n");
+      VG_(printf)("couldn't stat dylinker: %s\n", filename);
       VG_(close)(fd);
       return -1;
    }
@@ -156,9 +152,7 @@
    err = load_mach_file(fd, 0, filesize, MH_DYLINKER, filename,
                         NULL, NULL, NULL, out_linker_entry, NULL);
    if (err) {
-      print("...while loading dylinker: ");
-      print(filename);
-      print("\n");
+      VG_(printf)("...while loading dylinker: %s\n", filename);
    }
    VG_(close)(fd);
    return err;


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Valgrind-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/valgrind-developers
Loading...