review for bug 375772

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

review for bug 375772

iraisr
Please have a look at the proposed patch for bug 375772 [1]:
+1 error in get_elf_symbol_info() when computing value of 'hi' address for ML_(find_rx_mapping)()

Kind regards,
I.

[1] https://bugs.kde.org/show_bug.cgi?id=375772

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Valgrind-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/valgrind-developers
Reply | Threaded
Open this post in threaded view
|

Re: review for bug 375772

Mark Wielaard
On Tue, 2017-01-31 at 05:12 +0100, Ivo Raisr wrote:
> Please have a look at the proposed patch for bug 375772 [1]:
> +1 error in get_elf_symbol_info() when computing value of 'hi' address for
> ML_(find_rx_mapping)()
>

Symbol sizes could be zero, which would cause this to make hi < lo. I
cannot immediately see if the code guards against that. Otherwise this
looks correct.

Cheers,

Mark

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Valgrind-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/valgrind-developers
Reply | Threaded
Open this post in threaded view
|

Re: review for bug 375772

iraisr


2017-01-31 13:19 GMT+01:00 Mark Wielaard <[hidden email]>:
On Tue, 2017-01-31 at 05:12 +0100, Ivo Raisr wrote:
> Please have a look at the proposed patch for bug 375772 [1]:
> +1 error in get_elf_symbol_info() when computing value of 'hi' address for
> ML_(find_rx_mapping)()
>

Symbol sizes could be zero, which would cause this to make hi < lo. I
cannot immediately see if the code guards against that. Otherwise this
looks correct.

Indeed, that was my worry as well. Fortunately get_elf_symbol_info() guards against
this problem at the beginning of this function.
Thank you for looking into it, Mark!
I.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Valgrind-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/valgrind-developers