Quantcast

vex: r3358 - /trunk/priv/guest_mips_toIR.c

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

vex: r3358 - /trunk/priv/guest_mips_toIR.c

svn-2
Author: petarj
Date: Wed May  3 15:34:02 2017
New Revision: 3358

Log:
mips: remove unnecessary code

After r16309, abiinfo->guest__use_fallback_LLSC is already set for Cavium,
and hence it is not necessary to check archinfo->hwcaps in VEX.

Modified:
    trunk/priv/guest_mips_toIR.c

Modified: trunk/priv/guest_mips_toIR.c
==============================================================================
--- trunk/priv/guest_mips_toIR.c (original)
+++ trunk/priv/guest_mips_toIR.c Wed May  3 15:34:02 2017
@@ -16988,8 +16988,7 @@
    case 0x30:  /* LL */
       DIP("ll r%u, %u(r%u)", rt, imm, rs);
       LOAD_STORE_PATTERN;
-      if (VEX_MIPS_COMP_ID(archinfo->hwcaps) == VEX_PRID_COMP_CAVIUM
-          || abiinfo->guest__use_fallback_LLSC) {
+      if (abiinfo->guest__use_fallback_LLSC) {
          t2 = newTemp(ty);
          assign(t2, mkWidenFrom32(ty, load(Ity_I32, mkexpr(t1)), True));
          putLLaddr(mkexpr(t1));
@@ -17007,8 +17006,7 @@
       if (mode64) {
          LOAD_STORE_PATTERN;
          t2 = newTemp(Ity_I64);
-         if (VEX_MIPS_COMP_ID(archinfo->hwcaps) == VEX_PRID_COMP_CAVIUM
-             || abiinfo->guest__use_fallback_LLSC) {
+         if (abiinfo->guest__use_fallback_LLSC) {
             assign(t2, load(Ity_I64, mkexpr(t1)));
             putLLaddr(mkexpr(t1));
             putLLdata(mkexpr(t2));
@@ -17025,8 +17023,7 @@
       DIP("sc r%u, %u(r%u)", rt, imm, rs);
       t2 = newTemp(Ity_I1);
       LOAD_STORE_PATTERN;
-      if (VEX_MIPS_COMP_ID(archinfo->hwcaps) == VEX_PRID_COMP_CAVIUM
-          || abiinfo->guest__use_fallback_LLSC) {
+      if (abiinfo->guest__use_fallback_LLSC) {
          t3 = newTemp(Ity_I32);
          assign(t2, binop(mode64 ? Iop_CmpNE64 : Iop_CmpNE32,
                           mkexpr(t1), getLLaddr()));
@@ -17060,8 +17057,7 @@
       if (mode64) {
          t2 = newTemp(Ity_I1);
          LOAD_STORE_PATTERN;
-         if (VEX_MIPS_COMP_ID(archinfo->hwcaps) == VEX_PRID_COMP_CAVIUM
-             || abiinfo->guest__use_fallback_LLSC) {
+         if (abiinfo->guest__use_fallback_LLSC) {
             t3 = newTemp(Ity_I64);
             assign(t2, binop(Iop_CmpNE64, mkexpr(t1), getLLaddr()));
             assign(t3, getIReg(rt));


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Valgrind-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/valgrind-developers
Loading...